apollo_transaction_converter: move transaction converter to its own crate #11705
+118
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2026
|
This change is |
This was referenced Jan 14, 2026
Contributor
Author
einat-starkware
changed the base branch from
einat/proof_manager/dont_write_rejected_txs
to
graphite-base/11705
einat-starkware
force-pushed
the
einat/tx_converter/crate
branch
from
be66354 to
6847e63
Compare
einat-starkware
changed the base branch from
graphite-base/11705
to
einat/proof_manager/log_times
einat-starkware
force-pushed
the
einat/tx_converter/crate
branch
from
6847e63 to
bbc890a
Compare
einat-starkware
force-pushed
the
einat/proof_manager/log_times
branch
from
0c485d8 to
043f994
Compare
einat-starkware
force-pushed
the
einat/proof_manager/log_times
branch
from
043f994 to
9cd9cc1
Compare
einat-starkware
force-pushed
the
einat/tx_converter/crate
branch
2 times, most recently
from
ea6ebd0 to
dbf82e2
Compare
einat-starkware
force-pushed
the
einat/proof_manager/log_times
branch
from
9cd9cc1 to
3ff98bb
Compare
einat-starkware
force-pushed
the
einat/proof_manager/log_times
branch
from
3ff98bb to
338d782
Compare
einat-starkware
force-pushed
the
einat/tx_converter/crate
branch
from
dbf82e2 to
862f47f
Compare
einat-starkware
force-pushed
the
einat/proof_manager/log_times
branch
from
338d782 to
a01c1d5
Compare
einat-starkware
force-pushed
the
einat/tx_converter/crate
branch
from
862f47f to
e996b2b
Compare
einat-starkware
force-pushed
the
einat/tx_converter/crate
branch
from
e996b2b to
690c3dc
Compare
einat-starkware
force-pushed
the
einat/proof_manager/log_times
branch
from
a01c1d5 to
7db3022
Compare
einat-starkware
changed the base branch from
einat/proof_manager/log_times
to
graphite-base/11705
einat-starkware
force-pushed
the
einat/tx_converter/crate
branch
from
690c3dc to
8230a30
Compare
einat-starkware
force-pushed
the
graphite-base/11705
branch
from
7db3022 to
77f4d67
Compare
einat-starkware
changed the base branch from
graphite-base/11705
to
einat/proof_manager/log_times
einat-starkware
force-pushed
the
einat/tx_converter/crate
branch
from
8230a30 to
7313faa
Compare
avi-starkware
approved these changes
Jan 20, 2026
Collaborator
avi-starkware
left a comment
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware partially reviewed 29 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).
Collaborator
|
Double import Suggestion: use apollo_transaction_converter::transaction_converter::{
TransactionConverterError,
TransactionConverterTrait,
}; |
einat-starkware
force-pushed
the
einat/tx_converter/crate
branch
from
7313faa to
ec69042
Compare
einat-starkware
force-pushed
the
einat/proof_manager/log_times
branch
from
77f4d67 to
4b097d6
Compare
einat-starkware
commented
Jan 20, 2026
Contributor
Author
einat-starkware
left a comment
einat-starkware
left a comment
There was a problem hiding this comment.
@einat-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 26 of 29 files reviewed, all discussions resolved (waiting on @avi-starkware).
crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs line 49 at r5 (raw file):
Previously, avi-starkware (Avi Cohen) wrote…
Double import
fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.